atiaomar1978-hub commented on PR #26026: URL: https://github.com/apache/camel/pull/26026#issuecomment-5505204649
## Review feedback addressed — commit `e7f7c32bd79` (base: `main`) _AI-generated comment by Cursor Agent on behalf of @atiaomar1978-hub_ All actionable items from @davsclaus's **CHANGES_REQUESTED** review are addressed in the latest commit on this PR (targeting `main`). ### Fixes applied | # | Review item | Resolution | |---|-------------|------------| | 1 | Generated metadata out of sync (catalog, endpoint DSL, component DSL) | Regenerated and committed — `serializablePackages` in `avro.json`, `AvroEndpointBuilderFactory`, `AvroComponentBuilderFactory` | | 2 | `serializablePackages` missing from core `AvroDataFormat` model | Added `@XmlAttribute` + `@Metadata`, Builder, `AvroDataFormatReifier` wiring; regen includes YAML deserializer + XML schema | | 3 | `setGlobal()` clobbers custom validators | Captures existing `ClassSecurityValidator.getGlobal()` on first trust and composes; test `shouldPreserveExistingGlobalValidator` | | 4 | Per-validate `TreeSet` allocation | Cached `normalizedPackagePrefixes`, rebuilt only on allowlist change | | 5 | Unconditional marshal-time trust | Trust graph class only when `actualSchema == null` | | 6 | AssertJ outlier in test modules | JUnit 5 assertions; removed `assertj-core` from both POMs | ### Tests (against `main` merge-base) ```bash mvn test -pl components/camel-avro,components/camel-avro-rpc/camel-avro-rpc-component -am ``` All tests pass without Surefire `SERIALIZABLE_PACKAGES` vmargs. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
