atiaomar1978-hub commented on PR #1907: URL: https://github.com/apache/camel-spring-boot/pull/1907#issuecomment-5506493466
## Rebased on main + review feedback addressed — commit `dc376d6f033` _AI-generated comment by Cursor Agent on behalf of @atiaomar1978-hub_ Thanks @Croway and @davsclaus for the reviews. This PR is now **rebased onto current `main`** (including #1917 `AbstractEarlyResolutionPropertiesParser`) and addresses all remaining feedback. ### Rebase (#1917) Precedence logic is integrated into the shared `AbstractEarlyResolutionPropertiesParser` base class instead of duplicating across eight individual parsers. Jasypt remains a standalone parser with the same guards. ### Fixes | Item | Resolution | |------|------------| | `putIfAbsent` + higher-precedence guard before backend contact | ✅ `EarlyResolutionPropertySources` + `AbstractEarlyResolutionPropertiesParser` | | Jasypt keeps `OriginTrackedValue`-only matching | ✅ No plain `String` branch added | | MapPropertySource limitation documented | ✅ Javadoc on `hasHigherPrecedenceProperty` | | Parser test: duplicate placeholders, highest wins | ✅ `preservesHighestPrecedencePlaceholderForDuplicateKeys` | | Parser test: higher-precedence plain suppresses lower placeholder | ✅ `skipsLowerPrecedencePlaceholderWhenHigherPrecedenceDefinesKey` | ### Tests ```bash mvn test -pl core/camel-spring-boot -Dtest=EarlyResolutionPropertySourcesTest,AbstractEarlyResolutionPropertiesParserTest mvn test -pl components-starter/camel-jasypt-starter -am ``` Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
