gnodet commented on code in PR #26042:
URL: https://github.com/apache/camel/pull/26042#discussion_r3914834704
##########
test-infra/camel-test-infra-milvus/src/main/java/org/apache/camel/test/infra/milvus/services/MilvusLocalContainerInfraService.java:
##########
@@ -66,6 +67,7 @@ public TestInfraMilvusContainer(boolean fixedPort) {
ContainerEnvironmentUtil.configurePorts(this, fixedPort,
ContainerEnvironmentUtil.PortConfig.primary(19530),
ContainerEnvironmentUtil.PortConfig.secondary(9091));
+ waitingFor(Wait.forLogMessage(".*Milvus Proxy successfully
initialized and ready to serve!.*", 1));
Review Comment:
`waitingFor()` replaces the **entire** wait strategy on the container —
including the one that received the 3-minute startup timeout set at line 64 via
`withStartupTimeout(Duration.ofMinutes(3L))`. The new `LogMessageWaitStrategy`
inherits the default **60-second** timeout from `AbstractWaitStrategy`.
Since `GenericContainer.withStartupTimeout()` delegates to
`getWaitStrategy().withStartupTimeout()` (i.e., it configures the *current*
strategy, not a container-level field), the 3-minute timeout at line 64 is now
effectively dead code.
On ppc64le with the older Milvus 2.6.5 image (the exact environment this PR
targets per the description), 60 seconds may not be enough for the proxy to
initialize, making this fix counterproductive.
The fix is to chain `.withStartupTimeout()` on the new strategy, following
the established pattern in other Camel test-infra services
(`CyberArkVaultLocalContainerInfraService`, `FhirLocalContainerInfraService`,
`DoclingLocalContainerInfraService`,
`McpEverythingSseLocalContainerInfraService`):
```suggestion
waitingFor(Wait.forLogMessage(".*Milvus Proxy successfully
initialized and ready to serve!.*", 1)
.withStartupTimeout(Duration.ofMinutes(3L)));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
