gnodet commented on PR #25273: URL: https://github.com/apache/camel/pull/25273#issuecomment-5510672519
All review findings have been addressed in the rebased commit (83b9dc9): 1. **Text segments lost in batch embed→store pipeline** — Fixed. The batch path now preserves text segments via a new `TEXT_SEGMENTS` header (`CamelLangChain4jEmbeddingsTextSegments`), added to `CamelLangchain4jAttributes` in `core/camel-api`. The embedding store producer reads text segments from this header first, falling back to the body. The embed→store pipeline now works seamlessly. 2. **Size mismatch not validated** — Fixed. Added explicit size checks before `addAll(callerIds, embeddings, textSegments)` and the `add(id, embedding)` loop. Throws `IllegalArgumentException` with clear sizes. 3. **Caller-supplied ID drops text segment** — Fixed. When both `EMBEDDING_ID` and `TEXT_SEGMENT` are present, uses `addAll(singletonList)` to preserve both. 4. **Upgrade guide entry** — Added entries for both `camel-langchain4j-embeddings` (batch embedding, new headers) and `camel-langchain4j-embeddingstore` (batch ADD/REMOVE, behavior change). 5. **Rebased onto current `main`** — Integrated with the new GenAI observation pattern and `resolveEmbedding()`/auto-embedding support. _Claude Code on behalf of @gnodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
