davsclaus commented on code in PR #26038:
URL: https://github.com/apache/camel/pull/26038#discussion_r3916455687
##########
core/camel-management/src/main/java/org/apache/camel/management/JmxManagementLifecycleStrategy.java:
##########
@@ -153,6 +153,9 @@ public class JmxManagementLifecycleStrategy extends
ServiceSupport implements Li
private final Map<BacklogTracer, ManagedBacklogTracer>
managedBacklogTracers = new HashMap<>();
private final Map<DefaultBacklogDebugger, ManagedBacklogDebugger>
managedBacklogDebuggers = new HashMap<>();
private final Map<Object, Object> managedThreadPools = new HashMap<>();
+ // route group MBean is shared by all routes in the same group, so its
performance counters
+ // aggregate the statistics across all the member routes
+ private final Map<String, ManagedRouteGroup> managedRouteGroups = new
HashMap<>();
Review Comment:
Non-blocking: `managedRouteGroups` is a plain `HashMap`, so
`computeIfAbsent`/`remove` here aren't synchronized. This is consistent with
the existing convention in this class (`managedThreadPools`,
`managedBacklogTracers`, `managedBacklogDebuggers` are all plain `HashMap`) and
route lifecycle events aren't concurrent, so no new risk is introduced — just
noting it for the record. No change requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
