Ganny-lp opened a new pull request, #6796:
URL: https://github.com/apache/camel-k/pull/6796

   Replace Camel K's own condition structs (IntegrationCondition, 
PipeCondition, BuildCondition, IntegrationKitCondition, 
IntegrationPlatformCondition, KameletCondition, CamelCatalogCondition) with the 
standard metav1.Condition type across all affected CRDs, backed by the 
k8s.io/apimachinery/pkg/api/meta helpers (FindStatusCondition, 
SetStatusCondition, RemoveStatusCondition).
   
   - FirstTruthyTime (per-condition) migrated to FirstReadyTimestamp (top-level 
status field), set only on the first transition to Ready=True.
   - DeprecatedPods promoted from a per-condition nested field to a top-level 
status field.
   - CRDs updated with x-kubernetes-list-type: map / list-map-keys: [type] on 
the conditions list, per standard Kubernetes conventions.
   - A conditionAdapter preserves the legacy ResourceCondition interface for 
existing call sites.
   - Regenerated: zz_generated.deepcopy.go, 
pkg/client/camel/applyconfiguration/**, all CRD YAMLs 
(pkg/resources/config/crd/bases and the Helm CRD bundle), and 
docs/modules/ROOT/partials/apis/camel-k-crds.adoc via script/gen_doc.sh.
   - Added unit tests for the migration logic and updated pre-existing 
assertions across trait/controller tests that compared .Status/.Type against 
the old typed condition constants.
   - Fixed isIntegrationUpdated(), which required FirstReadyTimestamp to 
already be set to detect a transition to Ready=True -- backwards, since that 
field is exactly what gets set as a result of the transition. The nil/zero 
guard was moved to the call site in integrationUpdateFunc, where 
FirstReadyTimestamp.Sub(startTime) is actually dereferenced.
   
   IntegrationProfile is intentionally left untouched: its condition field was 
already marked DeprecatedIntegrationProfileCondition prior to this change.
   
   Fixes #5191
   
   <!-- Description -->
   
   
   
   
   <!--
   Please, describe the PR intent carefully, linking it to the github issue 
that it wants to address.
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to