gnodet commented on code in PR #26211:
URL: https://github.com/apache/camel/pull/26211#discussion_r3958908821


##########
.github/workflows/check-container-versions.yml:
##########
@@ -35,7 +35,7 @@ on:
 
 jobs:
   upgrade-container-versions:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-slim

Review Comment:
   ⚠️ **Risk: hard 15-minute wall on ubuntu-slim**
   
   This job runs a Python loop that creates one PR per outdated container, with 
a 2-second sleep between iterations, plus `pip install` on cold start and a 
`workflow_dispatch` call per container. If N containers are outdated, the loop 
runs for roughly `N × (pip+python+gh pr create+sleep)` seconds — easily 15+ 
minutes on a single vCPU when N ≥ 10.
   
   ubuntu-slim imposes a **hard, non-overridable 15-minute job limit**. The job 
will be silently killed mid-loop if it runs long, leaving some containers 
without upgrade PRs — and with no obvious failure signal (the job itself is 
marked failed, but the root cause is timeout, not a script error).
   
   The other 6 workflows in this PR are all sub-minute and safe to migrate. 
This one is not — it belongs on `ubuntu-latest`.
   
   ```suggestion
       runs-on: ubuntu-latest
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to