davsclaus opened a new pull request, #26399: URL: https://github.com/apache/camel/pull/26399
https://issues.apache.org/jira/browse/CAMEL-24714 Since CAMEL-10698 the model marks the expression options the reifiers evaluate as predicates with `@AsPredicate`, and the catalog carries it as `"asPredicate": true` on the option in `models/*.json`. Nothing read it though, and one site was unmarked. - **Model:** `PredicateValidatorDefinition.expression` is reified with `createPredicate` but was not annotated (`predicateValidator.json` now carries `asPredicate`). Loop stays unannotated: its expression is a predicate only when `doWhile` is true, which a flag on the option cannot say — documented on `@AsPredicate`. - **camel-jbang `SimpleChecks`** (the write-time Simple check of `SourceValidator`, CAMEL-24698) looks the parent EIP up in the catalog instead of the hardcoded `PREDICATE_EIPS` list: the expression option of the EIP itself (filter, when, validate, onWhen) or an expression option of the EIP above it (handled/continued/retryWhile of onException, completionPredicate of aggregate), kebab-case included; loop checks its `doWhile` sibling. The `loopDoWhile`/`loop-do-while` entries were dead (the YAML key is `loop` with `doWhile: true`) and go. - **Drift test:** `AsPredicateModelTest` (camel-core) reifies every predicate site with a spy language and asserts the options marked `asPredicate` in the model JSON are exactly the ones the reifiers evaluate with `createPredicate`, with split/transform/setBody as expression contrast. No new `@Metadata` attribute and the JSON key stays `asPredicate`, so no catalog consumer is affected. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
