squakez commented on code in PR #6807:
URL: https://github.com/apache/camel-k/pull/6807#discussion_r4005696840
##########
pkg/resources/resources_test.go:
##########
@@ -123,32 +119,14 @@ func TestResourcesWithPrefix(t *testing.T) {
}
func TestTemplateResource(t *testing.T) {
- fname := "master-role-lease.tmpl"
- name := "myintegration-master"
- ns := "test-nm"
-
- templateData := struct {
- Namespace string
- Name string
- ServiceAccount string
+ data, err := TemplateResource("/resources/testdata/template.tmpl",
struct {
Review Comment:
if `TemplateResource()` was only used in master trait, then it can be
removed (as well as this test).
##########
pkg/resources/resources/testdata/template.tmpl:
##########
@@ -0,0 +1 @@
+name: {{ .Name }}
Review Comment:
It seems this is required by some test. I suspect we can remove the test and
the business logic which was likely only used in master test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
