gnodet-bot commented on code in PR #26404:
URL: https://github.com/apache/camel/pull/26404#discussion_r4013335620
##########
components/camel-minio/pom.xml:
##########
@@ -29,8 +29,8 @@
<artifactId>camel-minio</artifactId>
<packaging>jar</packaging>
- <name>Camel :: MinIO</name>
- <description>Store and retrieve objects from Minio Storage
Service</description>
+ <name>Camel :: MinIO (Deprecated)</name>
+ <description>Store and retrieve objects from Minio Storage Service
(Deprecated)</description>
Review Comment:
🔍 **Convention (two issues):**
1. `<name>` uses `(Deprecated)` (capital D). Every other deprecated
component uses lowercase `(deprecated)`: `Camel :: Paho (deprecated)`, `Camel
:: OGNL (deprecated)`, `Camel :: OpenTelemetry (deprecated)`.
2. `<description>` must not receive the suffix at all. Same evidence:
`camel-paho`, `camel-ognl`, `camel-opentelemetry` all leave `<description>`
unchanged. This is the established pattern, not a style preference.
```suggestion
<name>Camel :: MinIO (deprecated)</name>
<description>Store and retrieve objects from Minio Storage
Service</description>
```
##########
components/camel-minio/src/generated/resources/META-INF/services/org/apache/camel/component.properties:
##########
@@ -3,5 +3,5 @@ components=minio
groupId=org.apache.camel
artifactId=camel-minio
version=4.23.0-SNAPSHOT
-projectName=Camel :: MinIO
-projectDescription=Store and retrieve objects from Minio Storage Service
+projectName=Camel :: MinIO (Deprecated)
+projectDescription=Store and retrieve objects from Minio Storage Service
(Deprecated)
Review Comment:
Same two issues as in `pom.xml`: wrong casing on `projectName` and the
`projectDescription` must not carry the suffix (it mirrors `<description>` in
pom.xml).
```suggestion
projectName=Camel :: MinIO (deprecated)
projectDescription=Store and retrieve objects from Minio Storage Service
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
