gnodet-bot commented on code in PR #26450:
URL: https://github.com/apache/camel/pull/26450#discussion_r4013323632
##########
core/camel-core-reifier/src/main/java/org/apache/camel/reifier/LoadBalanceReifier.java:
##########
@@ -47,6 +47,18 @@ public Processor createProcessor() throws Exception {
"To many outputs configured on " +
definition.getLoadBalancerType() + ": " + size + " > " + max);
}
+ Boolean inherit = parseBoolean(definition.getInheritErrorHandler());
+ Boolean childInherit = inherit;
+ if (definition.getLoadBalancerType() instanceof
FailoverLoadBalancerDefinition failover) {
+ // special for failover load balancer where you can configure it to
+ // not inherit error handler for its children (so it fails over
+ // immediately on an error instead of waiting for the error handler
+ // to exhaust its redeliveries), but the load balancer itself
should
+ // inherit so Camels error handler can react afterwards
Review Comment:
**Nit:** "Camels error handler" → "Camel's error handler" (missing
possessive apostrophe).
```suggestion
// inherit so Camel's error handler can react afterwards
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
