Croway opened a new pull request, #1757:
URL: https://github.com/apache/camel-website/pull/1757

   ## Summary
   - make prose inside documentation tabs readable on the dark panel
   - add a compact inset around introductory tab prose
   - cover prose-before-code tabs in the local Antora fixture
   
   This applies to all documentation tab panels, including [Enabling 
Tracing](https://camel.apache.org/manual/tracer.html#_enabling_tracing).
   
   ## Verification
   - [10:35:58] Using gulpfile 
~/Repositories/apache/camel-website/antora-ui-camel/gulpfile.js
   [10:35:58] Starting 'bundle'...
   [10:35:58] Starting 'clean'...
   [10:35:58] Finished 'clean' after 9.83 ms
   [10:35:58] Starting 'lint:css'...
   [10:35:58] Starting 'lint:js'...
   [10:35:59] Finished 'lint:js' after 515 ms
   [10:35:59] Finished 'lint:css' after 880 ms
   [10:35:59] Starting 'test'...
   ✔ bails out when the vendor bundle failed to load (1.144625ms)
   ✔ bails out when the search container is absent from the page (0.308125ms)
   ✔ over-fetches so the client-side filtering has material to work with 
(0.287ms)
   ✔ excludes sub-project hits for "timer" (1.032083ms)
   ✔ keeps one page from monopolizing the results for "timer" (0.399ms)
   ✔ excludes sub-project hits for "kamelet" (0.68775ms)
   ✔ keeps one page from monopolizing the results for "kamelet" (0.305958ms)
   ✔ excludes sub-project hits for "routing" (0.555959ms)
   ✔ keeps one page from monopolizing the results for "routing" (0.462334ms)
   ✔ gives every hit the type DocSearch needs to render a title (0.52075ms)
   ✔ titles a sub-heading hit with its own heading, not the page heading 
(0.332625ms)
   ✔ ranks core documentation ahead of component reference pages (0.494083ms)
   ✔ core documentation survives DocSearch grouping as the first rendered group 
(0.431458ms)
   ✔ declares the theme on .DocSearch rather than :root (0.599166ms)
   ✔ gives the theme custom properties literal values (0.542917ms)
   ✔ sizes the search box in rem so the query text is not clipped (0.135709ms)
   ✔ restates the vendor properties that are derived from other custom 
properties (0.059625ms)
   ✔ drops the resolved definitions from a top-level :root rule (2.793ms)
   ✔ drops the resolved definitions when :root is part of a selector list 
(0.331917ms)
   ✔ drops the resolved definitions from a top-level html rule but keeps its 
other declarations (0.228125ms)
   ✔ preserves scoped custom properties, which postcss-custom-properties does 
not substitute (0.512792ms)
   ✔ preserves a :root rule nested in an at-rule, which 
postcss-custom-properties does not substitute (0.313041ms)
   ✔ breaks a class name in the Type column before each camel-case hump 
(29.033333ms)
   ✔ breaks an enum constant in the Default column after the underscore 
(4.356209ms)
   ✔ still breaks a property name in the first column after dots and before 
humps (3.462083ms)
   ✔ leaves short tokens and plain prose words alone (3.433666ms)
   ✔ breaks an identifier in prose at its humps rather than leaving it to 
hyphenation (4.811458ms)
   ✔ marks identifiers, short ones included, so the browser never hyphenates 
them (3.373375ms)
   ✔ leaves plain words, trailing punctuation included, free to hyphenate 
(2.866209ms)
   ✔ still breaks a token in prose that is too long to wrap whole (3.221458ms)
   ✔ still breaks a long value a description quotes as code (3.32625ms)
   ✔ never changes the text a reader sees or copies (6.381667ms)
   ✔ does not touch code blocks inside a cell (2.604375ms)
   ℹ tests 33
   ℹ suites 0
   ℹ pass 33
   ℹ fail 0
   ℹ cancelled 0
   ℹ skipped 0
   ℹ todo 0
   ℹ duration_ms 557.259875
   [10:35:59] Finished 'test' after 561 ms
   [10:35:59] Starting 'build'...
   gulp-imagemin: Minified 27 images (saved 4.94 kB - 7.7%)
   [10:36:02] Finished 'build' after 2.8 s
   [10:36:02] Starting 'bundle:pack'...
   [10:36:02] Antora option: 
--ui-bundle-url=/Users/fmariani/Repositories/apache/camel-website/antora-ui-camel/build/ui-bundle.zip
   [10:36:02] Finished 'bundle:pack' after 47 ms
   [10:36:02] Finished 'bundle' after 4.3 s
   - Rendered: 
/Users/fmariani/Repositories/apache/camel-website/tests/antora-ui/out/fixture/4.18/getting-started.html
   
   Visual result: introductory prose uses the site's muted on-dark color, with 
a 6px top inset and 2px bottom inset before the code block.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to