carlesarnal commented on PR #24844: URL: https://github.com/apache/camel/pull/24844#issuecomment-5678283597
Review follow-up pushed in ec3345e10c8, after rebasing onto current main. - **JIRA:** the existing issue is [CAMEL-24172](https://issues.apache.org/jira/browse/CAMEL-24172), filed by the PR author. Claus linked this PR in its July discussion. The PR title and description now reference it, as does the new fix commit. - **Build/generated files:** both module parents and first-version metadata now use 4.23; catalog JSON/docs, BOM, main/dependency indexes, documentation symlinks/navigation, and both DSL factories are included. - **Credentials/architecture:** username and clientId are no longer marked secret; password/clientSecret use `secret=true`. Verified the 3.3.0 image supports amd64, arm64, ppc64le, and s390x. - **Client lifecycle:** the SDK client/adapter has no close method. The endpoint now provides and closes its own Vert.x instance, including failed-start cleanup. Caller-supplied clients survive restart. Tests cover lifecycle and actual Basic/OIDC HTTP exchanges. - **Validation:** catches only the SDK `RuleViolationProblemDetails`, reads detail/title (SDK getMessage can be null), clears stale errors, and propagates auth/network/server errors. Negative container tests configure a BACKWARD rule and assert false/error headers and failOnValidation=true exceptions. - **Content/docs:** schema definitions are textual inputs to VersionContent; AVRO/PROTOBUF here refer to schema definitions, not serialized records. Retrieval returns byte[] and closes streams. Documented URI group-ID delimiter limitations, header overrides, replay/watermark behavior, and that validate checks proposed schema versions rather than application payloads. - **Tests:** migrated to AssertJ; added content-close, fetchContent, missing-ID, repeat-poll/new-version, create/update header overrides, missing-artifact, authentication and lifecycle coverage. The create/update/delete/search lifecycle is exercised against the real registry; deletion is now enabled explicitly in test infra and asserted. - **Earlier fixes retained:** removed unused cacheTtl/HEADER_DRY_RUN, shared dry-run helper, sorted global IDs, and unit coverage for searchArtifacts/validate/testCompatibility. Validation: 35 unit tests and 8 integration tests passed across the full component run and final targeted producer run. Formatting/import sorting and generation goals completed. Full all-component/DSL builds were not run; DSL generation used the component module because the local Maven repository lacks unrelated Camel snapshots. _AI-generated response by OpenCode on behalf of @carlesarnal._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
