oscerd opened a new pull request, #26470: URL: https://github.com/apache/camel/pull/26470
## What Aligns the resource schemes named in the CAMEL-24292 upgrade-guide entry, and documents one behaviour delta that entry left out. ## Why The entry added by #26268 names the schemes `SqlHelper.resolveQuery` handles in three places, and the three disagree — with the `@UriParam` on `SqlStoredEndpoint` saying a fourth thing: | Where | Said | |---|---| | guide, "was resolved through" | `file:` / `http:` / `classpath:` | | guide, "never as a … resource" | `file:` / `http:` | | guide, `useMessageBodyForTemplate` paragraph | `file:`, `http:`, `https:` or `classpath:` | | `SqlStoredEndpoint.allowTemplateFromHeader` | `file:/http:` | The third is the complete list. On a security gate this is not cosmetic: a reader checking whether the gate covers their case could conclude from the shorter lists that `classpath:` and `https:` header templates are still resolved. They are not. ## Also @davsclaus flagged a delta for users who opt **back in** that the entry does not mention. `SqlHelper.resolveQuery` applied placeholder resolution only to a value that had a scheme, so a schemeless header template previously reached the database untouched; it now always goes through `SqlHelper.resolvePlaceholders`, which drops `--` comment lines and blank lines and re-joins the rest with newlines. Immaterial for the single-line call syntax a stored-procedure template normally uses, but a route passing a multi-line commented template through the header will see the comments stripped. Framed as what an opted-in user would notice — for everyone else the header is off and the delta is unreachable. ## Why separately Both items were raised by @davsclaus and the review bot on #26268, on both rounds. The code changes from that review landed; these did not make the merge. Re-landing rather than losing them. ## Scope Documentation only — the guide entry plus one `@UriParam` description, with the catalog regenerated. `main` only, no behaviour change. Full reactor build green. _Claude Code on behalf of @oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
