davsclaus commented on PR #26506: URL: https://github.com/apache/camel/pull/26506#issuecomment-5695622503
Thanks for picking these up. I had already started on the same items in #26505 (it began as the jt400 fix and now covers 8–12 plus the unfinished netty-http item from #26451), so I checked each change here against the runtime and folded the good parts in there. Closing this one in favour of #26505; the differences, per item: - **12 jt400** — `objectPath.type` is still one token to the catalog (`SYNTAX_PATTERN` is `[\w.]+`), so every example still fails with `Unknown option 'objectPath.type'`. #26505 makes the syntax `…/objectPath` and drops `type` as a path option: the component derives it from the object suffix after `setProperties`, it was never settable. - **9 xmpp** — dropping `required` is right, but the documented no-port URIs also fail at runtime: `XmppComponent` passes `URI.getPort()` = `-1` to the endpoint, which only defaults on `0`, and Smack's `setPort(-1)` throws. #26505 adds `defaultValue = "5222"` and skips the `setPort` when the URI has no port. - **10 huggingface** — changing `task` to `String` regresses custom predictors: `TaskPredictorFactory` now calls `HuggingFaceTask.valueOf(config.getTask())` *before* the `predictorBean` branch, so `huggingface:custom?predictorBean=…` throws `IllegalArgumentException`. It also changes the public `getTask()` type. #26505 adds `CUSTOM` to the enum instead and keeps the type. - **11 salesforce** — the `@UriParam` (and your description, kept as is) is right but not enough: the build fails with `Empty doc for option: actionType` because `ApprovalRequest` is `@UriParams` with `@UriParam(required = true)` fields from the Camel 2 era, which the generator now descends into (and would mark `approval.actionType` required on every URI). And the catalog still reports `approval.actionType` unknown — only `Map` options accept `option.key`. #26505 removes the dead annotations and generalises the catalog rule to bean options. - **8 olingo2/4** — `apiName` stays `required = true` with no default in the diff (the description says otherwise), so validation now fails with *missing required apiName*; `methodName` swallows `read/Manufacturers` and is never checked against the API's methods. A real `resourcePath` path option would break `configureProperties` (it binds known options into the configuration and removes them from the API-method args). Both components are deprecated, so #26505 leaves them in the `CatalogDocExamplesTest` skip list with a permanent reason. Only the huggingface JSON was regenerated here; the other five components, the catalog and endpoint-dsl were not, so the uncommitted-changes check would have caught it. The quickest way to see all of this is to drop a page from `PAGES_SKIPPED` in `CatalogDocExamplesTest` and run it — that is what the list is for. _Claude Code on behalf of -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
