gnodet-bot commented on code in PR #26508:
URL: https://github.com/apache/camel/pull/26508#discussion_r4025278313
##########
components/camel-jt400/src/main/docs/jt400-component.adoc:
##########
@@ -202,20 +202,20 @@ In this example, the camel route will call the QUSRTVUS
API to retrieve
._Java-only: uses lambda Processor to set program call parameters_
[source,java]
----
-from(“timer://foo?period=60000”)
+from("timer://foo?period=60000")
.process( exchange -> {
- String usrSpc = “MYUSRSPACEMYLIB “;
+ String usrSpc = "MYUSRSPACEMYLIB ";
Object[] parms = new Object[] {
usrSpc, // Qualified user space name
1, // starting position
16, // length of data
- “” // output
+ "" // output
};
exchange.getIn().setBody(parms);
})
-
.to(“jt400://*CURRENT:*CURRENt@localhost/qsys.lib/QUSRTVUS.PGM?fieldsLength=20,4,4,16&outputFieldsIdx=3”)
- .setBody(simple(“${body[3]}”))
- .to(“direct:foo”);
+
.to("jt400://*CURRENT:*CURRENt@localhost/qsys.lib/QUSRTVUS.PGM?fieldsLength=20,4,4,16&outputFieldsIdx=3")
Review Comment:
🔤 **Nit:** `*CURRENt` — lowercase `t` looks like a typo for `*CURRENT`
(AS/400 special value). The PR touches this exact line for the quote fix; easy
to correct here.
```suggestion
.to("jt400://*CURRENT:*CURRENT@localhost/qsys.lib/QUSRTVUS.PGM?fieldsLength=20,4,4,16&outputFieldsIdx=3")
```
##########
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/docs/jt400-component.adoc:
##########
@@ -202,20 +202,20 @@ In this example, the camel route will call the QUSRTVUS
API to retrieve
._Java-only: uses lambda Processor to set program call parameters_
[source,java]
----
-from(“timer://foo?period=60000”)
+from("timer://foo?period=60000")
.process( exchange -> {
- String usrSpc = “MYUSRSPACEMYLIB “;
+ String usrSpc = "MYUSRSPACEMYLIB ";
Object[] parms = new Object[] {
usrSpc, // Qualified user space name
1, // starting position
16, // length of data
- “” // output
+ "" // output
};
exchange.getIn().setBody(parms);
})
-
.to(“jt400://*CURRENT:*CURRENt@localhost/qsys.lib/QUSRTVUS.PGM?fieldsLength=20,4,4,16&outputFieldsIdx=3”)
- .setBody(simple(“${body[3]}”))
- .to(“direct:foo”);
+
.to("jt400://*CURRENT:*CURRENt@localhost/qsys.lib/QUSRTVUS.PGM?fieldsLength=20,4,4,16&outputFieldsIdx=3")
Review Comment:
🔤 **Nit:** Same `*CURRENt` typo in the generated catalog mirror — needs the
same fix as in the component source.
```suggestion
.to("jt400://*CURRENT:*CURRENT@localhost/qsys.lib/QUSRTVUS.PGM?fieldsLength=20,4,4,16&outputFieldsIdx=3")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
