jamesnetherton commented on PR #26515: URL: https://github.com/apache/camel/pull/26515#issuecomment-5711306297
> @jamesnetherton there is too much information on your comment. I'm not sure to follow. Yeah - sorry for that! The commit comment states: > replacing the Pump to preserve the behavior of exception But it's not strictly true. Replacing `Pump` with `pipe()` introduces some subtle changes. `Pump` threw away the result of every `response.write()`, so failures were invisible. `pipe()` propagates them. So for scenarios where requests are aborted (e.g. due to client disconnect), you now get an additional log message & stack trace. Which could perhaps get a bit 'spammy'. If you'd like, I could contribute some simple changes for `AsyncInputStream` on the PR to fix that. Or we could merge this as-is and I could follow up later. Let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
