davsclaus opened a new pull request, #26559: URL: https://github.com/apache/camel/pull/26559
JIRA: https://issues.apache.org/jira/browse/CAMEL-24772 `OllamaDoctorSupportTest.detectReturnsNotRunningWhenEndpointUnreachable` failed on every machine with Ollama on the default port, all three surefire attempts. The test assumed `withUrl("http://127.0.0.1:1";)` pins the client, but `OllamaDoctorSupport.detect` is a discovery: an explicit URL that does not answer is followed by the `camel infra run ollama` PID files and `localhost:11434`, which is what a doctor probe is for. Production behaviour is right; the test encoded the wrong contract. Test-only change. The test now asserts the discovery semantics on every kind of host: it first runs the plain discovery to learn whether the host has an Ollama of its own, then detects with the unreachable URL and expects - on a host without Ollama: not running, no base URL, no models (the old assertions); - on a host with Ollama: running, with the base URL the discovery found and never the unreachable one. So the negative path keeps its coverage in CI, and a developer's laptop with Ollama up asserts the fallback instead of failing. The javadoc on the test says why, so the next reader does not restore the old assumption. Verified with Ollama running locally (the branch that used to fail) and by the shape of the other branch, which is the previous test unchanged. _Claude Code on behalf of davsclaus_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
