davsclaus commented on code in PR #26584:
URL: https://github.com/apache/camel/pull/26584#discussion_r4046375993
##########
components/camel-http-common/src/main/java/org/apache/camel/http/common/CamelServlet.java:
##########
@@ -59,6 +59,12 @@ public class CamelServlet extends HttpServlet implements
HttpRegistryProvider {
public static final String ASYNC_PARAM = "async";
public static final String FORCE_AWAIT_PARAM = "forceAwait";
public static final String EXECUTOR_REF_PARAM = "executorRef";
+ /**
+ * Request attribute holding the {@link CompletionStage} of a request
still being processed on another thread when
+ * {@link #doService(HttpServletRequest, HttpServletResponse)} returns.
The {@link AsyncContext} must not be
+ * completed before it.
+ */
+ public static final String ASYNC_PROMISE_ATTRIBUTE_NAME =
"CamelAsyncPromise";
Review Comment:
Non-blocking: only `CamelServlet` itself reads and writes this attribute.
Since `doService()` is a protected extension point, `public` is defensible so a
subclass that fully replaces `doService()` can hand over its own stage — but if
that is not the intent, `protected` would keep it off the public API surface.
Either is fine with me; just flagging it since it is new public API on a class
that gets backported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
