davsclaus commented on code in PR #26595:
URL: https://github.com/apache/camel/pull/26595#discussion_r4046994037
##########
dsl/camel-kamelet-main/src/main/known-third-party-libraries.properties:
##########
@@ -145,10 +146,10 @@ com.fasterxml.jackson.dataformat.yaml =
com.fasterxml.jackson.dataformat:jackson
com.fasterxml.jackson.dataformat.csv =
com.fasterxml.jackson.dataformat:jackson-dataformat-csv:${jackson2-version}
com.google.gson = com.google.code.gson:gson:${gson-version}
com.alibaba.fastjson = com.alibaba:fastjson:${fastjson-version}
-org.eclipse.yasson = org.eclipse:yasson:${yasson-version}
+org.eclipse.yasson = org.eclipse.yasson:yasson:${yasson-version}
Review Comment:
Applied in fc316ad56e6a as a comment on the line: the org.eclipse.yasson
group id exists from 3.0.5 on, and a branch on 3.0.4 or earlier needs
org.eclipse:yasson. main is on 3.0.5, so the mapping resolves here; the note is
for whoever backports.
##########
dsl/camel-kamelet-main/src/test/java/org/apache/camel/main/download/KnownDependenciesResolverTest.java:
##########
@@ -66,7 +66,7 @@ void theShippedMappingResolvesThirdPartyClassesByPackage() {
assertGav(resolver, "org.postgresql.ds.PGConnectionPoolDataSource",
"org.postgresql", "postgresql");
assertGav(resolver, "org.h2.jdbcx.JdbcDataSource", "com.h2database",
"h2");
assertGav(resolver, "com.zaxxer.hikari.HikariConfig", "com.zaxxer",
"HikariCP");
- assertGav(resolver,
"org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory",
"org.apache.activemq",
+ assertGav(resolver,
"org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory",
"org.apache.artemis",
"artemis-jakarta-client-all");
Review Comment:
Applied in fc316ad56e6a: the test now also pins
org.eclipse.yasson.internal.Unmarshaller to org.eclipse.yasson:yasson and
com.univocity.parsers.csv.CsvParser to com.sonofab1rd:univocity-parsers (the
lookup matches by package, so the assertions hold for any class in those
packages).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
