gnodet-bot commented on code in PR #26604:
URL: https://github.com/apache/camel/pull/26604#discussion_r4050507542
##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/ExampleBrowserPopup.java:
##########
@@ -224,11 +250,18 @@ void render(Frame frame, Rect area) {
}
void renderFooter(List<Span> spans) {
- TuiHelper.hint(spans, "r", "run");
- TuiHelper.hint(spans, "Enter", currentFolder != null ? "run..." :
"open");
- TuiHelper.hint(spans, "d", "docs");
- // inside a category Esc returns to the top level, at the top level it
closes the browser
- TuiHelper.hintLast(spans, "Esc", currentFolder != null ? "back" :
"close");
+ if (currentFolder != null) {
+ TuiHelper.hint(spans, "r", "run");
+ TuiHelper.hint(spans, "Enter", "run...");
+ TuiHelper.hint(spans, "d", "docs");
+ // inside a group Esc, Left and Backspace return to the groups; at
the top level Esc closes the browser
+ TuiHelper.hintLast(spans, "Esc", "back");
Review Comment:
**Hint bar inconsistency:** the code comment on line 257 says _"Esc, Left
and Backspace return to the groups"_ and the key handlers are correctly wired
(lines 123–128), but the visible hint shown to the user still says only
`"Esc"`. The `"Enter/→"` hint at line 260 correctly advertises the Right key
for the forward direction; the back direction should mirror that.
```suggestion
TuiHelper.hintLast(spans, "Esc/←", "back");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
