gnodet-bot commented on code in PR #26640:
URL: https://github.com/apache/camel/pull/26640#discussion_r4059678931
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/YamlLines.java:
##########
@@ -111,6 +112,40 @@ private static String siblingValue(String line, int
indent, String option) {
return unquote(trimmed.substring(trimmed.indexOf(':') + 1).trim());
}
+ /** The roots of a Simple expression: ${body...}, ${header.x},
${date:...}: a value evaluated as Simple is fine. */
+ private static final java.util.Set<String> SIMPLE_ROOTS =
java.util.Set.of("body", "bodyAs", "mandatoryBodyAs",
Review Comment:
💡 **Nit: fully-qualified `java.util.Set` without an import — same issue as
the `HashSet` just fixed in `EndpointChecks.java`.**
The file imports only `java.util.regex.Matcher` and
`java.util.regex.Pattern`; `java.util.Set` is used as a FQN on this line and
the `java.util.Set.of(...)` call. Add the import and drop the qualifier for
consistency.
```suggestion
private static final Set<String> SIMPLE_ROOTS = Set.of("body", "bodyAs",
"mandatoryBodyAs",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
