oscerd commented on code in PR #26541:
URL: https://github.com/apache/camel/pull/26541#discussion_r4061504119
##########
components/camel-vertx/camel-vertx-websocket/src/main/java/org/apache/camel/component/vertx/websocket/VertxWebsocketProducer.java:
##########
@@ -60,13 +60,18 @@ public boolean process(Exchange exchange, AsyncCallback
callback) {
}
Map<String, WebSocketBase> connectedPeers =
getConnectedPeers(exchange);
- VertxWebsocketResultHandler vertxWebsocketResultHandler
- = new VertxWebsocketResultHandler(exchange, callback,
connectedPeers.keySet());
if (connectedPeers.isEmpty()) {
+ // nothing was sent, so the exchange is done here rather than
from a write handler
+ LOG.warn("No WebSocket peer to send to for endpoint {}, the
message is not delivered",
Review Comment:
Agreed, and done in 8a77a8f — a status push on a timer with no browser
attached would have logged a warning every tick, and that is a normal state for
a broadcast, not a fault.
The empty-peer line in `process` is now DEBUG. The misconfiguration keeps
its WARN exactly where you said it already lives: `getConnectedPeers` still
warns per connection key that matches no peer, which is the case where the
route asked for a specific peer and did not get one.
92 module tests green, full reactor green.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
