gnodet-bot commented on code in PR #26676: URL: https://github.com/apache/camel/pull/26676#discussion_r4061562873
########## components/camel-mail/src/main/docs/mail-component.adoc: ########## @@ -299,14 +299,16 @@ cannot be overridden by message headers: [options="header"] |=== -| Option | Default | Effect when set to `false` -| `useHeaderRecipients`| `true` | Endpoint URI to/cc/bcc always used; To/CC/BCC headers ignored. -| `useHeaderFrom` | `true` | Endpoint URI from always used; From/Sender headers ignored. -| `useHeaderSubject` | `true` | Endpoint URI subject always used; Subject header ignored. -| `useHeaderReplyTo` | `true` | Endpoint URI replyTo always used; Reply-To header ignored. +| Option | Default | Effect when set to `true` +| `useHeaderRecipients`| `false` | Message To/CC/BCC headers can override the endpoint URI recipients. +| `useHeaderFrom` | `false` | Message From/Sender headers can override the endpoint URI sender. +| `useHeaderSubject` | `false` | Message Subject header can override the endpoint URI subject. +| `useHeaderReplyTo` | `false` | Message Reply-To header can override the endpoint URI replyTo. |=== -All four default to `true` so existing behaviour is preserved. Example: +All four default to `false`. Set to `true` to let message headers override the endpoint configuration. Review Comment: ⚠️ **Summary sentence is correct but the section context (not in diff) is inverted.** The new summary `"All four default to \`false\`. Set to \`true\` to let message headers override the endpoint configuration."` is correct. However, the surrounding prose (lines 294–298, not changed in this PR) says *"Four opt-in `@UriParam` options let you **lock** the endpoint configuration"* — which is now backwards. With default=`false` the lock is the default state; setting `true` unlocks it. The phrase "opt-in to lock" should become "opt-in to allow header overrides" (or similar). Please fix the intro paragraph in the same commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
