gnodet-bot commented on code in PR #26684: URL: https://github.com/apache/camel/pull/26684#discussion_r4063974984
########## components/camel-ai/camel-jev/src/main/java/org/apache/camel/component/jev/JevUncertainResultException.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.jev; + +import org.apache.camel.CamelException; + +/** A Noul probability within the predicate's configured uncertainty band. */ +public class JevUncertainResultException extends CamelException { Review Comment: ⚠️ **Routing blocker — `JevUncertainResultException` is not catchable via `onException`** `CamelException` extends `Exception` (checked). `RuntimeCamelException.wrapRuntimeCamelException()` wraps any non-`RuntimeCamelException` — so when `matches()` throws `JevUncertainResultException`, callers receive `RuntimeCamelException(cause=JevUncertainResultException)`. `onException(JevUncertainResultException.class)` does not fire. The doc works around this by saying "available through Camel's exception cause chain" — but the whole point of having a named, typed exception is that routes can catch it directly, like they do for every other Camel component exception (`MQTTException`, `JdbcSQLException`, etc.). Fix: extend `RuntimeCamelException`. `wrapRuntimeCamelException` will then return the exception as-is (the `instanceof RuntimeCamelException` branch short-circuits), making `onException(JevUncertainResultException.class)` work as expected. The test assertion changes from `hasCauseInstanceOf` to `isInstanceOf`. ```suggestion public class JevUncertainResultException extends RuntimeCamelException { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
