Suhail98 opened a new issue, #6843: URL: https://github.com/apache/camel-k/issues/6843
Follow-up from #6832, as suggested in review. `RootCmdOptions` carries two contexts: ```go RootContext context.Context `mapstructure:"-"` Context context.Context `mapstructure:"-"` ``` They used to be different: `Context` was a cancellable child of `RootContext`, so `kamel run --sync` could cancel the in-flight command and rerun it when a file changed, while `RootContext` kept the process alive. #6832 removed `--sync` and `--dev`, and with them the only caller of that cancel func, so it also dropped the child context. `NewKamelCommand` now sets both fields to the same `ctx`. Proposal: - drop `RootContext` and keep `Context` - its only reader is the `<-o.RootContext.Done()` wait point after `--logs` in `pkg/cmd/run.go`, which becomes `<-o.Context.Done()` with no change in behaviour I'm happy to pick this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
