oscerd commented on PR #26746:
URL: https://github.com/apache/camel/pull/26746#issuecomment-5810791189
Thanks for the re-review, @davsclaus.
Applied the message wording nit in 67de505 — both `determineKey` and
`determineBucketName` now read `"… is not set, or resolved to null."`.
On the scope question: agreed this narrows CAMEL-20971, and worth being
explicit. The evaluation sat after the header/config merge so it applied to
both, but the only thing relying on producer-side evaluation of a
header-supplied `${...}` was the dynamic-key IT, which is migrated here to the
configured `keyName` (the documented path). The idiomatic
`.setHeader(AWS2S3Constants.KEY, simple("${...}"))` pre-evaluates in the route
and is unaffected, and `keyName=RAW(${...})` is unchanged — so
configured/route-author dynamic keys keep working; only a literal `${...}`
inherited on the header is now used verbatim. As the CAMEL-20971 author, can
you confirm that is the intended scope before this goes in?
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
