Copilot commented on code in PR #1998:
URL:
https://github.com/apache/camel-spring-boot/pull/1998#discussion_r4100214897
##########
tooling/camel-spring-boot-generator-maven-plugin/src/main/java/org/apache/camel/springboot/maven/SpringBootAutoConfigurationMojo.java:
##########
@@ -1279,11 +1279,12 @@ private void createLanguageConfigurationSource(String
packageName, LanguageModel
for (LanguageOptionModel option : model.getOptions()) {
checkReservedOptionName("language", model.getName(),
option.getName());
// skip option with name id, or expression in language as we do not
- // need that and skip resultType as they are not global options
+ // need that and skip resultType, trim, resolveResource as they
are not global options
if ("id".equals(option.getName()) ||
"expression".equals(option.getName())
- || "resultType".equals(option.getName())) {
+ || "resultType".equals(option.getName()) ||
"trim".equals(option.getName())
+ || "resolveResource".equals(option.getName())) {
Review Comment:
GitHub Copilot on behalf of the human operator: This filter removes the
properties from generated configuration classes, but the regeneration is
incomplete: for example, `XQueryLanguageConfiguration` no longer declares them
while `components-starter/camel-saxon-starter/src/main/docs/saxon.json:107-124`
and `docs/spring-boot/modules/ROOT/pages/starters/xpath.adoc:39,44` still
advertise `resolve-resource` and `trim`; the same mismatch remains for the
other affected starters. Please regenerate and commit all corresponding JSON
and Asciidoc metadata so users are not directed to properties that now fail
strict binding.
This issue also appears on line 1283 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
