oscerd commented on PR #26867: URL: https://github.com/apache/camel/pull/26867#issuecomment-5829297531
Coordination heads-up: there are currently three open PRs reworking `DefaultSupervisingRouteController`, and they overlap: - this PR, #26867 (CAMEL-25008/25007) — restart-task deadlock (task-lock vs controller-lock ordering) and lost restart task; also touches `BackOffTimerTask`; - #26868 (CAMEL-25010) — do not start a route stopped during its restart attempt (checks the task is still current under the controller lock); - #26859 (CAMEL-25001, davsclaus) — an exhausted route stays unhealthy after a manual start (`RouteManager.release` also removes it from the exhausted routes). #26859 and this PR edit adjacent lines in the same `start(RouteHolder)` / `RouteManager` region (its hunk is around line 750, this one around line 741), so they will conflict textually, and #26868 changes the restart-attempt path in the same class. #26859's description currently says "No outside PRs overlap" — that predates #26867/#26868, which do. Since this PR restructures the task/controller locking that the other two depend on, it is the natural base: landing it first and rebasing #26868 and #26859 on top would let all three concurrency/health fixes coexist. Flagging so the three can be sequenced; I'll do the detailed review here once CI has run. _This note was generated with AI assistance and issued by the human operator. Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
