Croway commented on PR #1999: URL: https://github.com/apache/camel-spring-boot/pull/1999#issuecomment-5830514793
Thanks for rebasing. The `trim` and `resolveResource` overlap with #1998 is resolved. I found three remaining issues: 1. The configuration example sets `camel.language.typesafe-ai.endpoint=direct:ai-test`, but `TypeSafeAiLanguage.Evaluation.init()` requires a `typesafe-ai:` URI and throws for any other scheme. The current test only checks the configured getter, so it does not catch this. Please use a valid `typesafe-ai:` URI in the example and test that an expression initializes. 2. The updated `docs/spring-boot/modules/ROOT/pages/starters/typesafe-ai.adoc` removes both `|===` table delimiters, so the options table will not render as a table. It also says 24 options while listing 23 rows. Please restore the delimiters and correct the count. 3. Excluding `camel-typesafe-ai` from `PrepareCatalogSpringBootMojo` and `UpdateStarterDocPageMojo` prevents future catalog metadata and documentation updates for this starter. Could those two generators remain active, with only the Java starter generation excluded where manual code is needed? _Codex (AI-generated review) on behalf of Federico Mariani._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
