urunni88 commented on PR #26872: URL: https://github.com/apache/camel/pull/26872#issuecomment-5830699853
Thanks for the review and for testing the Vert.x path. You're right, it still does the substring match. If it helps, I could extend this PR: move the check into a static helper in camel-http-base, have DefaultHttpBinding.isFileNameAccepted delegate to it, and switch VertxPlatformHttpConsumer to it as well, with a test for the evil.x case. @oscerd As CAMEL-24652 is assigned to you and covers the Vert.x part. Would it be okay if I extended this PR to include it, or would you prefer to handle it as part of CAMEL-24652? Happy to go either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
