allthingssecurity commented on code in PR #27072:
URL: https://github.com/apache/camel/pull/27072#discussion_r4132911126
##########
core/camel-management/src/main/java/org/apache/camel/management/mbean/ManagedPerformanceCounter.java:
##########
@@ -315,14 +320,21 @@ public void processExchange(Exchange exchange, String
type) {
@Override
public void completedExchange(Exchange exchange, long time) {
+ exchangesInflight.decrement();
+ if (!statisticsEnabled) {
+ return;
+ }
increment();
exchangesCompleted.increment();
- exchangesInflight.decrement();
if (ExchangeHelper.isFailureHandled(exchange)) {
failuresHandled.increment();
lastExchangeFailureHandledTimestamp.updateValue(System.currentTimeMillis());
}
+ // a redelivery attempt that succeeds is also a redelivery
+ if (ExchangeHelper.isRedelivered(exchange)) {
Review Comment:
`CamelRedelivered` stays `true` after a successful redelivery
(`RedeliveryErrorHandler` only removes it when exhausted and handled or
continued). So every later processor and route in the exchange counts a
redelivery here. With your flaky route plus two more steps and a call to
another route, each of those reports `Redeliveries=1`.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
