oscerd commented on issue #1615:
URL:
https://github.com/apache/camel-kamelets/issues/1615#issuecomment-5887971269
Closing. The failure this issue was filed for is no longer reproducible, and
everything that reaches AsciiDoctor is clean.
Verified against the current tree:
- **Kamelet descriptions and property examples** — parsed all 250 Kamelets,
searched every `description` and `example` for attribute-reference-shaped text:
**0 occurrences**. `simple-filter-action`, the original trigger, no longer
carries an `example` on its `expression` property at all.
- **camel-k pipe examples** —
`templates/pipes/camel-k/simple-filter-action-pipe.yaml` has the escape applied
(`"\\${body} contains 'John'"`), and no other file under that directory
contains an unescaped `${`.
- **Doc partials** — no `${...}` in any `docs/modules/ROOT/partials/*.adoc`.
The one unescaped copy,
`templates/pipes/core/simple-filter-action-pipe.yaml`, never reaches the docs
build: `docs/modules/ROOT/examples/js/kamelets.js` reads only
`templates/pipes/camel-k/`, and `templates/pipes/core/` (170 files) is not
referenced by any `.js`, `.adoc`, `.go` or `.yaml` in the docs pipeline. That
divergence is deliberate — escaping it would corrupt the example for anyone
using those files directly.
**What is not done, and why closing anyway.** The issue asked for a
systematic escape rather than a hand-applied backslash, and the right place for
that is escaping on render in `kamelets.js` so the sources stay literal. That
file is consumed by the camel-website Antora build, which cannot be run from
this repository, so making the change here would mean altering rendering logic
for 250 pages blind — to prevent a warning that currently does not occur.
If an unescaped `{word}` ever reintroduces the warning, this is worth
reopening with the render-side fix done by someone who can verify the website
output.
---
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
