davsclaus commented on PR #27082: URL: https://github.com/apache/camel/pull/27082#issuecomment-5908549008
Follow-up: my previous review was written against 4e03971 and crossed with 438d870 / dc1a33c, which already address all three points. Thanks: 1. Source positions: routes are now parsed from the original resource stream with a `ModelParser` subclass that skips the validated `<semantic>` subtree, so location and line numbers are kept. 2. Dotted file names: declarations are detected in ordinary `*.xml` resources, so `my.tickets.xml` works. 3. MCP: `camel-semantic` is now test scope only, and the guard resolves `SemanticQuestions` reflectively. Remaining small points on the new design: - **Upgrade guide:** `camel-semantic` is new in 4.23 (`firstVersion` 4.23.0), so nobody upgrades from an older behaviour. The upgrade guide is for migration only; please drop the "camel-semantic - automatic XML route loading" section. The `semantic-language.adoc` update already documents it. - With `camel-semantic` on the classpath, `SemanticXmlLoader` now fronts **all** XML route loading: every XML resource is cached and gets an extra StAX pass in `hasDeclarations()`, which reads to the end of the document when there are no declarations. Consider skipping each depth-2 `route` subtree, or stopping once you are past the `<routes>` children. Minor. - `SemanticXmlLoader.isSupportedExtension()` does a `findByType(RoutesBuilderLoader.class)` registry lookup on every call. Minor. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
