davsclaus commented on code in PR #27104:
URL: https://github.com/apache/camel/pull/27104#discussion_r4146727126
##########
components/camel-hivemq/src/main/java/org/apache/camel/component/hivemq/HiveMQConfiguration.java:
##########
@@ -56,7 +63,8 @@ public class HiveMQConfiguration implements Cloneable {
private boolean retained;
/**
- * Whether to initiate a clean start (MQTT 5) upon connecting to the
broker.
+ * Whether to initiate a clean session upon connecting to the broker
(called "clean session" in MQTT 3.1.1 and
+ * "clean start" in MQTT 5).
Review Comment:
This still does not cover the behaviour difference from my earlier review.
On MQTT 5 the client sends a session expiry of 0, so `cleanStart=false` still
ends the session on disconnect. On 3.1.1 `cleanSession=false` makes the broker
keep the session (subscriptions and queued QoS 1/2 messages) with no time
limit. Could you add one sentence here, and ideally in the "MQTT protocol
version" section of `hivemq-component.adoc`? For example: _"With MQTT 3.1.1,
`cleanStart=false` makes the broker keep the session indefinitely; with MQTT 5
the session expires on disconnect."_ You will need to regenerate the
catalog/DSL files afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
