gnodet-bot commented on code in PR #27156:
URL: https://github.com/apache/camel/pull/27156#discussion_r4148589162
##########
components/camel-jackson3xml/src/main/java/org/apache/camel/component/jackson3xml/JacksonXMLDataFormat.java:
##########
@@ -471,74 +483,143 @@ public String getDisableFeatures() {
}
/**
- * Set of features to disable on the Jackson {@link XmlMapper}. The
features should be a name that matches a enum
- * from {@link SerializationFeature}, {@link DeserializationFeature}, or
{@link MapperFeature}.
+ * Set of features to disable on the Jackson {@link
tools.jackson.dataformat.xml.XmlMapper}. The features should be
+ * a name that matches an enum from {@link
tools.jackson.databind.SerializationFeature},
+ * {@link tools.jackson.databind.DeserializationFeature}, {@link
tools.jackson.databind.MapperFeature},
+ * {@link tools.jackson.databind.cfg.DateTimeFeature}, {@link
tools.jackson.databind.cfg.EnumFeature},
+ * {@link tools.jackson.databind.cfg.JsonNodeFeature}, {@link
tools.jackson.core.StreamReadFeature},
+ * {@link tools.jackson.core.StreamWriteFeature}, {@link
tools.jackson.dataformat.xml.XmlReadFeature} or
+ * {@link tools.jackson.dataformat.xml.XmlWriteFeature}.
*/
public void setDisableFeatures(String disableFeatures) {
this.disableFeatures = disableFeatures;
}
public void enableFeature(SerializationFeature feature) {
if (enableFeatures == null) {
- enableFeatures = feature.name();
+ enableFeatures = feature.getDeclaringClass().getSimpleName() + "."
+ feature.name();
Review Comment:
💡 **Nit:** Missing braces — this is the only `trySet*` method where the
null-check is braceless. All other nine methods (and the parent PR #26937) use
`if (feature == null) {`. Minor style inconsistency.
```suggestion
if (feature == null) {
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
