allthingssecurity commented on PR #27159: URL: https://github.com/apache/camel/pull/27159#issuecomment-5927053862
Thanks for the review. Docker is not available on my machine, so I ran the ITs against a local Apache Cassandra 5.0.9 instead (the binary tarball from downloads.apache.org, the same version as the test-infra image `cassandra:5.0.9`), started with a 1 GB heap on `localhost:9042`, with the module's `initScript.cql` schema. For these runs only (nothing of this is committed): - `BaseCassandra` used the test-infra remote service (`-Dcassandra.instance.type=remote -Dcassandra.host=localhost -Dcassandra.cql3.port=9042`), with its Docker check (`ContainerTestService`) overridden. Otherwise every test is skipped with "Docker is NOT available", also for the remote service. - `testConfirmExist` is `@DisabledOnOs(OS.MAC)`, and I removed that annotation so the reworked test runs here. - The aggregation tables were truncated before each run, because unlike a fresh container the local instance keeps the rows of the previous run. Results (`mvn verify` of camel-cassandraql with `-Dit.test='CassandraAggregation*IT,NamedCassandraAggregationRepositoryIT'`, JDK 21): - With this PR: `CassandraAggregationRepositoryIT` 10/10, `NamedCassandraAggregationRepositoryIT` 10/10, `CassandraAggregationIT` 1/1, `CassandraAggregationSerializedHeadersIT` 1/1. That is 22 tests, 0 failures, 0 skipped. The 8 unit tests also pass. I ran it twice, on a new and on a truncated keyspace. - With main's `CassandraAggregationRepository` and the reworked ITs (negative control): 6 of 22 fail, which are `testConfirmExist`, `testScan` and `testRecover` in both ITs. `testConfirmExist` fails because `remove` kept nothing under `camel-recovery:Exchange_2`. `testScan` fails because `scan` returns the open aggregations. `testRecover` fails because `recover` returns the open aggregation `Exchange-Recover1`. The other 16 pass. I updated the testing section of the PR description to match. A run against the container in CI would still be good to have. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
