gnodet-bot commented on code in PR #27181:
URL: https://github.com/apache/camel/pull/27181#discussion_r4152959294
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/SourceValidator.java:
##########
@@ -398,11 +399,35 @@ public static BeanDeclarations scan(Path directory,
String excludeFile) {
}
/** The YAML DSL schema errors in words: the node they are about and the
message without parser noise. */
+ /**
+ * Whether the expression whose language key is on the given line of a
YAML route is evaluated as a predicate by the
+ * EIP it belongs to (the expression of a filter or a when, the
completionPredicate of an aggregate).
+ *
+ * @param lines the lines of the YAML route
+ * @param lineIdx the index of the line of the language key (simple:)
+ */
Review Comment:
💡 **Missing `@param catalog`.** The Javadoc covers `lines` and `lineIdx` but
not `catalog`.
```suggestion
/**
* Whether the expression whose language key is on the given line of a
YAML route is evaluated as a predicate by the
* EIP it belongs to (the expression of a filter or a when, the
completionPredicate of an aggregate).
*
* @param catalog the Camel catalog for language/EIP model lookups
* @param lines the lines of the YAML route
* @param lineIdx the index of the line of the language key (simple:)
*/
```
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/SourceValidator.java:
##########
@@ -398,11 +399,35 @@ public static BeanDeclarations scan(Path directory,
String excludeFile) {
}
/** The YAML DSL schema errors in words: the node they are about and the
message without parser noise. */
Review Comment:
💡 **Orphaned Javadoc.** This comment was the Javadoc for
`formatSchemaErrors`, but the new `isYamlPredicate` was inserted between them.
Now it documents nothing — `isYamlPredicate` has its own Javadoc, and the
`formatSchemaErrors(errors, content)` overload also has its own. Remove it.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
