allthingssecurity commented on PR #27161: URL: https://github.com/apache/camel/pull/27161#issuecomment-5926717217
Thanks for the review, all three points are addressed in c7ba567 (rebased on main): 1. Order on stop: both `doStop()` methods now call `setLeader(false)` first, which fires the event while the leader key is still held, and only then remove the leader key (in a `finally`) and the membership entry, as `FileLockClusterView` does since CAMEL-25089. As the key still holds the local member at that point, `LocalMember.setLeader(false)` no longer reports the local member as the new leader in the event. The test checks that the leader key was still held when the listener ran, and is removed afterwards. 2. Upgrade guide: added "camel-infinispan - clustered routes stop when the Infinispan cluster view is stopped" to the 4.23 guide, next to the file lock entry. It also mentions that a leader key refresh error gives up the leadership until the next refresh. 3. Membership errors: the task is split into a leader key step and a membership step, each catching its own exception. Only an error in the leader key step gives up the leadership. An error on the membership `put` is logged and the leadership is kept. New test `leadershipIsKeptAfterAMembershipError` covers it, next to the leader key error test. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
