davsclaus commented on code in PR #27216:
URL: https://github.com/apache/camel/pull/27216#discussion_r4157290001
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesRun.java:
##########
@@ -807,7 +807,7 @@ private Integer deployProject(String workingDir, boolean
reload) throws Exceptio
}
private void detectCluster() {
- if (!disableAuto) {
+ if (!disableAuto && clusterType == null) {
Review Comment:
This block does two jobs: detecting the cluster type and applying the
per-cluster defaults (minikube: `imageBuilder=docker`, `imagePush=false`;
openshift: `imageGroup` = namespace). With `clusterType == null` in the
condition, an explicit `--cluster-type=minikube` now skips the defaults and
builds with jib + push to `localhost:5000`, which fails unless the registry
addon is enabled. Suggest: detect only when `!disableAuto && clusterType ==
null`, then apply the per-cluster defaults from the resolved `clusterType`
(explicit or detected).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
