gnodet-bot commented on code in PR #27264:
URL: https://github.com/apache/camel/pull/27264#discussion_r4164605566
##########
components/camel-ai/camel-openai/src/main/java/org/apache/camel/component/openai/McpToolCallExecutor.java:
##########
@@ -109,7 +109,7 @@ protected void doStop() throws Exception {
* @return one result per tool call, in the same order
* @throws Exception when a tool call fails and the configured strategy is
to fail the exchange
*/
- List<ToolResult> execute(List<ChatCompletionMessageToolCall> toolCalls)
throws Exception {
+ List<ToolResult> execute(List<ChatCompletionMessageToolCall> toolCalls,
Exchange callingExchange) throws Exception {
Review Comment:
📝 **Missing `@param` (re-raised from previous review).** The javadoc (lines
106–111) documents `toolCalls` but not the new `callingExchange` parameter. Add:
```suggestion
List<ToolResult> execute(List<ChatCompletionMessageToolCall> toolCalls,
Exchange callingExchange) throws Exception {
```
Can't suggest the javadoc addition itself since those lines aren't in the
diff, but please add:
```java
* @param callingExchange the exchange driving the agent loop; copied
into each route-tool invocation so the caller's context (properties, variables)
reaches the tool route
```
between the `@param toolCalls` and `@return` lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
