davsclaus opened a new pull request, #27295:
URL: https://github.com/apache/camel/pull/27295

   ## Summary
   
   [CAMEL-24793](https://issues.apache.org/jira/browse/CAMEL-24793): until now, 
only Turbo Pascal had its own code colors. Every other theme used Monokai 
(dark) or GitHub (light). On some themes that was hard to read, with comments 
at a contrast of 2.5 on Nord, Catppuccin Frappé and Everforest. It also clashed 
with the rest of the screen, for example pink keywords on Nord or Solarized.
   
   - **16 themes** now use their color scheme's own code colors, from each 
scheme's published mapping:
     - Dracula
     - Nord and Nord Light
     - Solarized Dark and Light
     - Gruvbox Dark and Light
     - Catppuccin Mocha, Frappé and Latte
     - Tokyo Night
     - Rosé Pine and Rosé Pine Moon
     - Kanagawa
     - Everforest and Everforest Light
   
     Nord has no light editor scheme, so Nord Light uses Nord's colors darkened 
for a light background.
   - **Readability:** 15 colors were below a 3:1 contrast on the TUI 
background, mostly comments plus some yellows and greens on light themes. Each 
one is made a little lighter (on dark themes) or darker (on light themes), 
keeping its hue. Each stylesheet comment lists which tokens were changed.
   - **Unchanged:** Dark, Light, Monochrome and CRT keep the built-in palette. 
Turbo Pascal keeps its own.
   - **`ThemeSyntaxPaletteTest`** checks every theme, including the fallback 
palette:
     - every code color has a contrast of at least 3:1 on `base-bg`;
     - keywords, strings and comments differ from each other and from plain 
code text;
     - a theme defines all 7 `syntax-*` tokens or none;
     - code text equals the theme's `base-fg`.
   
     I checked that the test fails when Nord's original comment color is put 
back (contrast 2.43).
   - **Docs:** the Theme section of the TUI settings page describes the code 
colors and has a screenshot. `theme.md` documents the rules for theme authors.
   
   Nord:
   
   
![Nord](https://raw.githubusercontent.com/apache/camel/fix/CAMEL-24793/docs/user-manual/modules/ROOT/images/jbang/camel-tui-theme-nord-source.png)
   
   ## Test plan
   
   - [x] `camel-jbang-plugin-tui`: 1688 tests pass, including 84 new checks (4 
checks × 21 themes)
   - [x] Live TUI: switched between Dracula, Nord and Gruvbox Light on a YAML 
route in the Source tab
   
   _Claude Code on behalf of davsclaus_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to