oscerd commented on PR #3082:
URL: https://github.com/apache/camel-kamelets/pull/3082#issuecomment-5978475023
Green, and worth landing for a reason beyond the bump itself: it closes a
version skew that is currently on `main`.
#3080 moved `maven-core.version` to 3.10.0 but left `maven-compat.version`
at 3.9.16, and `kamelets-maven-plugin` declares both. Resolved from `main` at
a21183e3c:
```
+- org.apache.maven:maven-core:jar:3.10.0:provided
| +- org.apache.maven:maven-model:jar:3.10.0:provided
| +- org.apache.maven:maven-settings:jar:3.10.0:provided
| +- org.apache.maven:maven-repository-metadata:jar:3.10.0:provided
+- org.apache.maven:maven-artifact:jar:3.10.0:provided
+- org.apache.maven:maven-plugin-api:jar:3.10.0:provided
+- org.apache.maven:maven-compat:jar:3.9.16:provided <-- odd one out
```
This PR brings `maven-compat` to 3.10.0 and they line up again.
**Calibrating the impact: it is cosmetic, not a latent bug.** I checked
rather than assuming. Nothing in the plugin's sources imports anything from
`maven-compat` — the full set of `org.apache.maven` imports across
`src/main/java` is:
```
org.apache.maven.plugin.AbstractMojo
org.apache.maven.plugin.MojoExecutionException
org.apache.maven.plugin.MojoFailureException
org.apache.maven.plugins.annotations.{LifecyclePhase, Mojo, Parameter}
org.apache.maven.project.MavenProject
```
all from `maven-plugin-api`, `maven-plugin-annotations` and `maven-core`.
And every one of these is `provided`, so the running Maven supplies its own
versions regardless of what we pin. So the skew is untidy rather than
dangerous, which is also why CI stayed green on #3080.
**A possible follow-up, flagged rather than asserted.** Since nothing
imports it, the `maven-compat` dependency may simply be unnecessary. Removing
it and running `mvn clean install -DskipTests` in
`library/kamelets-maven-plugin` succeeds, plugin descriptor generation
included. I have **not** run a full root build in that configuration, which is
what would actually exercise the plugin, so I am not claiming it is safe to
drop — just that it looks unused and might be worth a separate look. Aligning
the version here is the right move either way.
No objection to merging.
---
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
