oscerd opened a new pull request, #27443:
URL: https://github.com/apache/camel/pull/27443

   ## Description
   
   [CAMEL-25375](https://issues.apache.org/jira/browse/CAMEL-25375). This 
follows up #27435 and addresses the three notes in the review of 12:14Z there.
   
   ## Changes
   
   1. **`handlers` on a producer.** `handlers` is a consumer option, and it now 
only counts as a security check of a WebSocket path when it is set on the 
consumer endpoint. Before, a producer that set it made its path close every 
connection, because producers do not run the handlers. A WARN on the producer 
side was left out on purpose: when the same URI is used in `from` and `to`, the 
producer shares the consumer's endpoint, so it would be logged for a working 
setup.
   2. **Same `securityConfiguration`.** Endpoints that configure the same 
`securityConfiguration` object are now treated as having the same security 
provider, even though each gets a provider instance of its own. They no longer 
log that the security settings of the producer are not used.
   3. **Servlet context of the first endpoint.** For the first endpoint of a 
server, the servlet deployment is started before the server again, so a failure 
leaves no server running, and a failure to start the server now undeploys it 
too. An endpoint that needs a servlet context later still wraps the running 
server, and a failure there only rejects the registration of that endpoint.
   
   ## Tests
   
   - 
`UndertowWsSecurityWithoutProviderTest#handlersOfAProducerDoNotGuardItsPath`
   - 
`CamelWebSocketHandlerSecuritySettingsTest#producerWithTheSameSecurityConfigurationAsTheConsumer`
   
   Both fail without the change. `camel-undertow` and 
`camel-undertow-spring-security` tests pass, and the full reactor build with 
`-DskipTests` passes.
   
   _Claude Code on behalf of Andrea Cosentino (oscerd)_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to