apupier commented on code in PR #27433:
URL: https://github.com/apache/camel/pull/27433#discussion_r4196244850
##########
core/camel-core/src/test/java/org/apache/camel/support/jsse/SSLContextParametersTest.java:
##########
@@ -1069,20 +1070,17 @@ public void testSignatureSchemesFilter_postJDK26()
throws Exception {
int defaultSignatureSchemeNumber =
getSignatureSchemes(engine.getSSLParameters()).length;
- // a filter cannot be applied as there are no default schemes to
filter, so the defaults are kept (null)
- // instead of an empty list (which would fail every handshake)
+ // empty filter - no includes means no schemes match (empty array)
Review Comment:
> * **Behaviour pinned here:** with defaults available, an empty
`FilterParameters` now yields zero signature schemes, which makes every
handshake fail. The null branch deliberately avoids that ("configuring an empty
list would fail every handshake"). Is an empty result the intended
`FilterParameters` semantics here, consistent with cipher suites? Or should the
production code also WARN, or keep the defaults, when the filter leaves nothing?
this is the point I do not understand the implications and what are the
implications so I don't know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
