davsclaus commented on PR #27448:
URL: https://github.com/apache/camel/pull/27448#issuecomment-6020560932
Thanks @Croway, agreed: "inside a jar" was the wrong test. Reworked in
7b5cf880f446 to decide by origin, as you suggested:
- **Only the Kamelet catalog is exempt.** Only a file under `kamelets/` in a
`camel-kamelets` jar skips the warning. This is matched on the resource
location and on its resolved URI, so `classpath:kamelets/...`, a scan of the
jar, and a jar nested in a Spring Boot jar are all treated the same.
- Your 1 and 2: the application's own jar and custom Kamelets warn again,
whether loaded explicitly or by wildcard.
- Your 3: other archive protocols warn as for any user file.
- **Lazy (your 4):** the check runs inside `warnCompactNotationOnce`, only
when a warning is about to be logged. Canonical files never trigger a lookup.
The `YamlRoutesBuilderLoaderSupport` change is reverted.
- **Minor points:** the class loader is restored in a `finally`. New tests
check that a user's jar and a plain classpath file still warn. `yaml-dsl.adoc`
documents the exemption.
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
