davsclaus commented on PR #3089:
URL: https://github.com/apache/camel-kamelets/pull/3089#issuecomment-6020910868
Thanks @Croway, you're right, and the description was wrong about comments.
Fixed in 88bca4c1d, generated again with apache/camel#27449 as it is now.
- **The comments are back.** The dump is of the route model, which has no
comments, so `camel validate normalize` now puts each comment block back before
the line it was written before. It walks the original and normalized templates
in order. All 82 comment lines of the 16 Kamelets are kept, in their order. The
one block whose line no longer exists (`mail-sink`, whose options stay in the
uri because the scheme is `{{protocol}}`) is placed right after that endpoint,
and the command reports such a case instead of dropping it.
- **Regenerating is now safe.** Normalizing the normalized Kamelets again
changes nothing. Checking that turned up three more things, all fixed:
- `azure-storage-files-source` had `share:
"{{shareName}}/{{directoryName}}"`, which the uri Camel builds from the options
breaks into `{}}`. It is now kept as written, as is any uri with a different
number of path parts than its syntax, or whose parse loses a `{{placeholder}}`.
- The options were in two different orders.
- Secret options get `RAW()` as Camel adds it at load time.
`./mvnw verify` passes, and #3090 is rebased on this.
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
