davsclaus commented on PR #27480:
URL: https://github.com/apache/camel/pull/27480#issuecomment-6033912748

   Thanks @oscerd, this looks good to go as-is once CI is green.
   
   One concern for after it's merged: this adds another component-specific 
`Type.Custom` event, next to the agentic events in camel-openai. That makes AI 
events hard to track for GenAI observability and for any other EventNotifier: 
each one needs a dependency on every AI component and an `instanceof` per event 
class, and the events aren't `ExchangeEvent`s. core/camel-api already has the 
`org.apache.camel.ai` package, so I've opened 
[CAMEL-25408](https://issues.apache.org/jira/browse/CAMEL-25408) for a common 
`AiEvent` API there, plus an AI value in `CamelEvent.Type` to use instead of 
`Custom`. The openai and ai-tool events would then move onto it before 4.23.0 
is released, so the component-specific events never ship. I've assigned it to 
you; please work on it next if you can.
   
   _Claude Code on behalf of davsclaus_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to