allthingssecurity commented on PR #27592: URL: https://github.com/apache/camel/pull/27592#issuecomment-6077663949
Thanks @oscerd. Addressed in 220535c: - **[Suggestion] docs sentence not true for `resultType=Boolean`** — done: the predicate section now lists the rules per result type. `byte[]`/`String`: `true`/`false` (any case) parsed, empty is `false`, any other value `true`. `Boolean`: only `true`/`false` (any case) are accepted, anything else (empty included) is `false`. `JsonNode`: only JSON `true`. The catalog copy is mirrored. I checked it locally with a throwaway case: a function returning `YES` matches with `byte[]`/`String` and does not with `Boolean`. - **[Nit] charset inconsistency** — no change. For `resultType=Boolean` the `byte[]` → `Boolean` conversion uses the type converter `ObjectConverter.toBoolean(byte[], Exchange)`, which decodes with `ExchangeHelper.getCharset(exchange)` and not `ObjectHelper.toBoolean`'s `new String(bytes)`. Both paths honour the exchange charset, and only ASCII `true`/`false` matter anyway. - **[Reminder] upgrade-guide collision with #27593** — still planned: I will merge the two camel-wasm notes under one heading when the second of the two PRs is rebased for merge. Tests: camel-wasm `install`, 9 tests, 0 failures (doc-only change). _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
