allthingssecurity commented on PR #27591: URL: https://github.com/apache/camel/pull/27591#issuecomment-6077649634
Thanks @oscerd. Addressed in c3d5509: - **[Suggestion] docker-env hint repeats on every dev-mode reload** — done: a `dockerEnvHintPrinted` guard in `detectCluster()`, pinned by `dockerEnvHintIsPrintedOnceAcrossReloads` (calls `detectCluster()` three times, expects the hint once). - **[Suggestion] bare `--image-push` untested** — done: `explicitMinikubeWithBareImagePushFlagPushes` passes `--cluster-type=minikube --image-push` and asserts `imagePush == TRUE` (so the Minikube no-push default does not override it). - **[Nit] `resolveKubernetesManifest(String, File, String)` ignores `extension`** — pre-existing and off the `KubernetesRun` path, so left out of this PR; it will go with the deferred `--output=json` follow-up. - **[Observation] `--output` needs a reachable cluster without `--cluster-type`** — agreed, unchanged here. Tests: `KubernetesRunClusterTypeTest` (10), `KubernetesHelperTest` (7), `KubernetesRunCustomTest` (9): 26 run, 0 failures. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
